Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeQL warnings #4348

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix CodeQL warnings #4348

merged 1 commit into from
Aug 17, 2024

Conversation

holgerfriedrich
Copy link
Member

Fix CodeQL warnings

  • Implicit narrowing conversion in compound assignment

This PR only fixes the first 4 of the warnings.
There are more CodeQL warnings left, help is appreciated:
https://github.com/holgerfriedrich/openhab-core/security/code-scanning

@holgerfriedrich
Fix CodeQL warnings
d131799 
* Implicit narrowing conversion in compound assignment

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner August 14, 2024 20:52
wborn
wborn approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 0e1883b into openhab:main Aug 17, 2024
5 checks passed
@wborn wborn added this to the 4.3 milestone Aug 17, 2024
@wborn
Copy link
Member

wborn commented Aug 17, 2024

There are more CodeQL warnings left, help is appreciated:
https://github.com/holgerfriedrich/openhab-core/security/code-scanning

It's a "404 not found" page for me.

@holgerfriedrich holgerfriedrich deleted the pr-codeql-integer branch August 18, 2024 02:12
@florian-h05
Copy link
Contributor

AFAIK only users with write access to a repo can access its CodeQL results.

@holgerfriedrich
Copy link
Member Author

AFAIK only users with write access to a repo can access its CodeQL results.

Then it might make sense to activate CodeQL scans, then at least the maintainers could see the report.
@openhab/core-maintainers WDYT? Shall I set it up?

@wborn
Copy link
Member

wborn commented Sep 7, 2024

Do you know how CodeQL compares to SonarCloud? That may be another tool to use for this. I've used SonarQube with SonarLint which also nicely integrates with your IDE. That prevents you from commiting such issues in the first place. 😉

@J-N-K
Copy link
Member

J-N-K commented Sep 7, 2024

I'm using SonarLint in IntelliJ (without SonarQube) and it's really nicely integrated.

@florian-h05
Copy link
Contributor

Do you know how CodeQL compares to SonarCloud?

No, unfortunately not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerfriedrich @wborn @florian-h05 @J-N-K